Fixing static data values

[JanOuborny]

Since the static data endpoint provides a lot of wrong or bad data (which is still persistent in v3). We should provide a function to fix all of this data. Riot is also recommending this solution by themselves. To start this we should start listing all know issues with the static api.

Known issues:

• Jungle items have no tags (Item ids: 1400, 1401, 1402, 1408, 1409, 1410, 1412, 1413, 1414, 1416, 1418, 1419)
• Nidalee's skill information is missing
• Data for Karma's w is wrong

[BenFradet]

I don't know about fixing the results ourselves, this doesn't seem like a good solution in the long-term (a lot of maintenance).

[JanOuborny]

I know that it comes with a lot of maintenance, therefore I wouldn't integrated completely into the api endpoint. I would rather offer an option for it. So that even if we are behind in updating the code, it doesn't break the whole endpoint.

[BenFradet]

I hear what you're saying however I personally think RiotSharp is meant to be "a dumb wrapper" ie people should expect the same things when using RiotSharp or hitting the API directly.

[toothlessG22]

I'm not sure if this would be feasible, but what if you allowed the user to add the missing data. Say you had a function that the user could access called overrideChampionStaticData(championId, championDto). You store that championDto so you can return it whenever the user calls for that specific id. I don't know how the caching feature works, but you might be able to leverage that by storing this championDto in the cache.

[JanOuborny]

In this case you could make the static api methods virtual and let the users do whatever they want with them. However, I like your idea, but I would take a more generic approach. I would provide a method RegisterDataProvider(IDataProvider<TEntity> provider) which registers a provider for the corrected data. This provider gets then called when populating the cache.

[JanOuborny]

Closed because of #564