BenFradet / RiotSharp

C# wrapper for the Riot Games API
http://benfradet.github.io/RiotSharp/
MIT License
300 stars 145 forks source link

Refactor StaticDataEndpoints to be more user friendly #644

Open JanOuborny opened 4 years ago

JanOuborny commented 4 years ago

At first the endpoint should be renamed to DataDragon to match Riot's documentation naming (the old static data api was deprecated a long time ago).

Also getting data should be simplified, for example getting a champion by its id should look like this: var champion = await ddragon.Champions.GetByIdÀsync(version, id); instead of: var champion= ddragon.Champions.GetAllAsync(latestVersion).Result.Champions.Values.Single(x => x.Id == id);

Endpoints to be refactored:

Capm96 commented 4 years ago

Hey @JanOuborny is this still up for grabs? I'd like to help out.

Thanks!

JanOuborny commented 4 years ago

Yes, it is still up for grabs. Go for it!