add first method in clash endpoint

BenFradet / RiotSharp

C# wrapper for the Riot Games API

http://benfradet.github.io/RiotSharp/

MIT License

300 stars 145 forks source link

add first method in clash endpoint #664

Closed Rezga12 closed 4 years ago

Rezga12 commented 4 years ago

Added one of five methods of The Clash Endpoint:

[x] /lol/clash/v1/players/by-summoner/{summonerId}
[ ] /lol/clash/v1/teams/{teamId}
[ ] /lol/clash/v1/tournaments
[ ] /lol/clash/v1/tournaments/by-team/{teamId}
[ ] /lol/clash/v1/tournaments/{tournamentId}

If the code looks okay, I will continue with other 4 methods.

Rezga12 commented 4 years ago

The code looks good, thanks 👍. However, I would open a different PR for each endpoint so that it's easier to review

Sorry I got little confused :(

I was going to push 4 more commits in this same branch for 4 remaining methods. But should I instead create new branch after implementing each of Four methods listed above?

BenFradet commented 4 years ago

yes, that would be great :+1: