Matchinfo GameDuration is incorrect when using Match-v5

BenFradet / RiotSharp

C# wrapper for the Riot Games API

http://benfradet.github.io/RiotSharp/

MIT License

300 stars 145 forks source link

Matchinfo GameDuration is incorrect when using Match-v5 #694

Closed Lunariz closed 3 years ago

Lunariz commented 3 years ago

Grabbing info for a game is giving me a match duration of 2 days, 8 hours and 26 minutes. I assume there is a milliseconds/seconds conversion going wrong somewhere!

I checked this game in particular, which happens to be a remake: EUW1_5394536774 API call gives Gameduration = 203157, which is 2:30 when parsed as milliseconds (correct) but 2d8h when parsed as seconds.

xXLAOKOONXx commented 3 years ago

You are completely write, conversion uses a seconds converter here https://github.com/BenFradet/RiotSharp/blob/95ec347911316869a12e0a101623c81a76252b5f/RiotSharp/Endpoints/MatchEndpoint/MatchInfo.cs#L27