search

BenGitsCode / today-i-learned

Easily digestible snippets of things learned in development, life and love (mostly development)
Other
3 stars 3 forks source link

Flexbox #32

Open cmigz opened 6 years ago

cmigz commented 6 years ago

Hope you like it! Let me know if you notice anything that needs to be fixed =)

Did a brief tutorial on flexbox, want to expand more on it but has the basics for now.

laurpaik-zz commented 6 years ago

Hey @cmigz ! I want to introduce myself before looking over this, since it's your first time contributing (and since Ben seems to be a bit busy right now)! My name is Lauren, and I was in Boston's WDI-016. Let me know if you have any questions on the feedback when I send it!

cmigz commented 6 years ago

Hi @laurpaik! It's nice to speak with you, my name is Christian. Looking forward to your feedback, thanks for looking it over!

cmigz commented 6 years ago

Haha @laurpaik I'm so glad to have had another set of eyes go over this, I never realize in the moment how much I tend to write run-on verbose sentences lol. Also love the suggestions for the tic marks for the property values and such, great idea. Soon as I get the chance I'll make all the suggested changes/additions and submit a new PR. I appreciate the fine-tooth combing, love this kind of collaboration =)

laurpaik-zz commented 6 years ago

@cmigz you actually won't need to submit a new PR if you push changes to the same branch. The new commits will simply be added to this PR, which'll be nice because I can see my suggestions before your changes too and we'll both get a sort of history log 😄 If you want an example, you can check out some of the closed pull requests that have a bunch of comments on them, like this.

cmigz commented 6 years ago

Hey @laurpaik!

Sorry I didn't do your fixes sooner! Hope you had a great holiday and new year!

Hope I hit all your suggestions, feel free to let me know anything I missed or any new edits when you get a chance.