feat: Add Splash Screen

BenGoBlue05 / UdacityAlumni

Udacity Alumni Android App

57 stars 30 forks source link

feat: Add Splash Screen #15

Closed PPartisan closed 7 years ago

PPartisan commented 7 years ago

Adds a simple splash screen using app branding [issue #9] screenshot_1484221818

Dvik commented 7 years ago

Instead of using PNG, consider using SVG images. Also, the files changed are more than the files actually changed by you. Please consider pulling the repo before pushing.

PPartisan commented 7 years ago

I went with a PNG because I'm not sure it's possible to use vector images in a layer-list drawable on API levels below 23 with correct scaling. Here's an example using the same vector image on API 22 and API 23 for comparison.

Apologies for the excess files included in the pull request. I did sync with the upstream repository first so I'm not sure why that's happened. I can look into removing them my end.

chashmeetsingh commented 7 years ago

Also @PPartisan next time you want to work on any issue, comment on that issue that you want to work on it so that others don't land up starting with the same issue 😄

PPartisan commented 7 years ago

Will do, thanks @chashmeetsingh :smile: