search

BenGoBlue05 / UdacityAlumni

Udacity Alumni Android App
57 stars 30 forks source link

Tapping on bookmark open the details activity #19

Closed Dvik closed 7 years ago

Dvik commented 7 years ago

Steps to reproduce

Tap on the list item to go to detail view Come back to list view. Tap on bookmark.

Expected behavior

The list item should be bookmarked

Actual behavior

The list item gets bookmarked and the detail view is also shown

Code Sample

Problem probably in onLoadFinished() of MainActivity (https://github.com/BenGoBlue05/UdacityAlumni/blob/master/app/src/main/java/com/google/developer/udacityalumni/activity/MainActivity.java)

This should not be there in onLoadFinished():


startActivity(new Intent(this, ArticleDetailActivity.class)
                    .putExtra(getString(R.string.article_list_key), ids)
                    .putExtra(getString(R.string.article_bookmarks_key), isBookmarked)
                    .putExtra(getString(R.string.tag_key), tags));
Dvik commented 7 years ago

Fixed in #22