search

BenGoBlue05 / UdacityAlumni

Udacity Alumni Android App
57 stars 30 forks source link

Used butterknife to replace onClickListener in LoginActivity on signInBtn #60

Closed knightcube closed 6 years ago

knightcube commented 6 years ago

Summary

Since we are using Butterknife i think we should stick to the @OnClick annotations to handle the button click instead of setOnCLickListener and finding the signInButton with findViewById method. Hence i replaced it.

Other Information

If there's anything else that's important and relevant to your pull request, mention that information here. This could include benchmarks, or other information.

Thanks for contributing to Udacity Alumni Group!

PPartisan commented 6 years ago

Looks good to me! Happy to merge once the conflict is resolved. Only comment I can make is maybe remove the Logging inside the onClick?

BenGoBlue05 commented 6 years ago

👍

knightcube commented 6 years ago

How can i resolve the conflicts? I had forked this project some days ago.....but now there are so many changes....does that mean i need to delete the repo and make a new forked repo again?.....or is there any other way to automatically merge changes into my existing forked repo?