feat: add skia as a renderer (creating abstracting package for canvases) - Githubissues

BenJeau / react-native-draw

SVG based data-driven React Native drawing component 🎨

https://www.npmjs.com/package/@benjeau/react-native-draw

MIT License

127 stars 42 forks source link

feat: add skia as a renderer (creating abstracting package for canvases) #50

Open BenJeau opened 2 years ago

BenJeau commented 2 years ago

Changes

Created @benjeau/react-native-draw-core utilities package for both renderers
Moved @benjeau/react-native-draw to @benjeau/react-native-draw-svg
Created @benjeau/react-native-draw-skia
Renamed packages folder (removed react-native-draw- prefix)
Added addPaths() and setPaths() ref functions

Things Left

[x] Have READMEs for all packages and create a new one for the root of the repo
[x] Document new props
[ ] Add examples for the new props
[ ] Add examples for the new Skia renderer
[ ] Make the Skia renderer properly handle the multiple paths within a single PathType (honestly debating if I should simply remove that feature)
[ ] Make sure that the grouping of the paths based on its props (color, thickness, opacity, filled, cap, join) is properly done

Related Issues

closes #38 closes #51 kinda closes #20 (there must be a better OR I do the same thing I do in Skia but within the SVG renderer)

Screenshots (optional)

BenJeau commented 2 years ago

Update - What is blocking me on this PR is the example. Since react-native-skia does not support expo at the moment, I've ported the code to a native react-native project, but I am getting some weird compilation errors on Android and iOS related to react-native-skia