search

BenLangmead / bowtie

An ultrafast memory-efficient short read aligner
Other
257 stars 76 forks source link

Makefile alphabet.cpp #95

Open xusailor opened 4 years ago

xusailor commented 4 years ago

In order to support the arm platform，the above code has been added.

junaruga commented 4 years ago

I faced this alphabet.cpp's error that prevents bowtie to be built with Fedora, gcc 10 & CPU architectures: aarch64 (arm64), s390x, ppc64le.

The -Wnarrowing is actually a build error on the environments.

alphabet.cpp:293:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]

This is a backport from bowtie2 commit: https://github.com/BenLangmead/bowtie2/commit/c619b9ab47ea1da67bee7258353d0791120384f4 .

And we need to fix alphabet.h too.

junaruga commented 4 years ago

Note: I sent PR to enable aarch64, s390x, ppc64le https://github.com/BenLangmead/bowtie/pull/102 .

ch4rr0 commented 4 years ago

Thanks for submitting this pull request, Jun. We already made a similar change to the codebase in the bug_fixes branch. Feel free to check out the changes we have on there.

junaruga commented 3 years ago

Thanks for the fixing! @xusailor you can close this PR. This PR was merged as the commit: https://github.com/BenLangmead/bowtie/commit/8a6d6ca9d3dc30ef5ef5636784f79969b61bb43e . You can also try to use the released bowtie 1.3.0 aarch64 (arm64) binary.