BenLangmead / bowtie2

A fast and sensitive gapped read aligner
GNU General Public License v3.0
638 stars 160 forks source link

cmake produces identical bowtie-align-l and bowtie-align-s files #433

Open OH-AU opened 1 year ago

OH-AU commented 1 year ago

Using cmake results in bowtie--l and bowtie--s in being identical files. Using the makefile to build the binaries results in different binaries for -l and -s files. Tested in the case of both v2.5.1 and v2.4.4.

ch4rr0 commented 1 year ago

Hello, thank you for reporting this issue.

This has been fixed with the most recent commit to the bug_fixes branch. If you find any additional issues with the CMake script please let us know.

OH-AU commented 1 year ago

Thank you for looking and fixing it so quickly. Referring to aefef02 ; using the CMakeFile there for 2.5.1, I get different binary files for bowtie2-align and bowtie2-build, however the binaries for bowtie2-inspect-{s/l} are still identical. Should this be the case?

ch4rr0 commented 1 year ago

Hello,

I pushed a commit to address the issue with bowtie2-inspect-l.

OH-AU commented 1 year ago

Thanks again - with the above commit ( eef707a ) all files now result in different binaries. ninja test passes all 5 tests. Should be good to close.