BenLangmead / qtip

Qtip: a tandem simulation approach for accurately predicting read alignment mapping qualities
MIT License
25 stars 7 forks source link

What version of sklearn is required for qtip #12

Open gui11aume opened 3 years ago

gui11aume commented 3 years ago

I am unable to use qtip from a fresh install on Ubuntu 14.04. Building works without problem, but testing fails with the error below:

make -C test
make: Entering directory `/home/gfilion/src/qtip/test'
...
File "/home/gfilion/src/qtip/fit.py", line 18, in <module>
from sklearn import cross_validation
ImportError: cannot import name 'cross_validation' from 'sklearn' (/home/gfilion/miniconda2/envs/python3/lib/python3.7/site-packages/sklearn/__init__.py)
make: *** [full_e2e/final.sam] Error 1
make: Leaving directory `/home/gfilion/src/qtip/test'

This Stack Overflow post explains that cross_validation was removed in version 0.20 of scikit-learn, but there is no indication of which version should be installed neither in the README nor in the .yaml file (as of this writing, the latest version is 0.24.1).

What version of scikit-learn should the users install?