Blueprint Overlapping - Githubissues

mattregul commented 5 years ago

Describe the bug Appears that rooms (and stockpiles) can overlap. This may be due to multiple gaming sessions. Always the same game & ai version, just multiple save/loads/enable df-ai's

Example 1: Overlapping didn't seem like much of an issue until I noticed that most of my fort was depressed and horrified, from constantly seeing bodies and bone refuse.
- Example 2: Dwarves were trapped down in the mines, as a z-level of their mineshaft was removed for a new fortress room. Noticed as I started seeing inaccessible item & dehydration/starvation messages.

Expected behavior Prevent structure overlapping or at least ensure bodies and refuse stockpiles are enclosed.

Visual reference

See top middle and bottom right
I was attempting to wall off the bones at top middle before taking screenshot
Also note the many blocks of stairways

ai version:

Dwarf Fortress 0.44.12
  Windows 64-bit
df-ai 0.44.12-r1-update1-6-gc32576d7 (Build ID: df-ai-pre-0.44.12-r1-180805000)
  code c32576d7b45f1336ad9f28272f6856655f80934e
DFHack 0.44.12-r1-0-gc2a64b35 (Build ID: df-ai-pre-0.44.12-r1-180805000)
  library c2a64b3573abbee549761f5c1c2626eec7a6e81c
  structures 23500e4e9bd1885365d0a2ef1746c321c1dd5094

mattregul commented 5 years ago

Does not seem to be related to multiple gaming sessions. Seeing overlap with fresh embark.

BenLubar commented 5 years ago

Ok, a few questions:

Is the AI generating a new layout every time it loads a save? It shouldn't be.
Do the room interiors overlap or is it just missing space for walls?
Is there a file named df-ai-plan.dat in your save folder (region#)?
Does the df-ai-plan.dat file increase significantly in size when you load and immediately save?

mattregul commented 5 years ago

Does not appear to be generating a new layout everytime, at least with my current save.
- I'll do some more testing tonight/overnight
I originally thought interiors overlap, as seen below... but maybe it is just missing walls? Hmm
- I'll do some more testing tonight/overnight
Yes (2.58 MB (2,707,456 bytes))
No, appears to stay the same.

mattregul commented 5 years ago

Looking more like walls/outer edge of blueprints aren't being taken into account when deciding placement?

mattregul commented 5 years ago

Definitely looking like its just missing walls

BenLubar / df-ai

Blueprint Overlapping #56