search

BenLubar / df-ai

Dwarf Fortress + Artificial Intelligence
https://benlubar.github.io/df-ai/
zlib License
246 stars 26 forks source link

version bump to work with LinuxLNP 0.43.03-r04 STABLE #8

Closed neoice closed 7 years ago

neoice commented 7 years ago

http://dffd.bay12games.com/file.php?id=11722

it's probably easier than updating the whole plugin to $latest. I'm not sure what they consider "stable", but I like the idea.

neoice commented 7 years ago

I compiled against dfhack at https://github.com/DFHack/dfhack/tree/0.43.03-r1

dfhack threw a warning on start, but it appears to be running df-ai without issue. it's been half an hour and it hasn't crashed yet :P

lethosor commented 7 years ago

What warning, specifically?

This plugin usually isn't hard to get working with new DFHack versions, especially in this case, since it had been compiled against 0.43.03-alpha1 before.

neoice commented 7 years ago

screenshot_2017-04-07_10-34-09

Warning: Plugin df-ai compiled for DFHack 0.43.03-r1-0-g98893793, running DFHack 0.43.03-r1-0-g9889379

g98893793 vs g9889379 ...

so I need to step my dfhack back a few commits and recompile df-ai? or LNP needs to update their dfhack?

that final version number is meaningless to me.

lethosor commented 7 years ago

That's actually the same version, just truncated to a different number of digits. The exact commit is https://github.com/dfhack/dfhack/commit/98893793bd19d359b75771279d694bff7dd34ede (98893793bd19d359b75771279d694bff7dd34ede). I'm guessing your git version is different from the one used to compile DFHack (which was probably mine, between 2.10 and 2.12). That warning should be harmless, then.

Edit: actually, it could be that DFHack recently passed the number of commits that causes git to report 8-digit hashes, because I'm getting 8 digits now, but 7 in 0.43.03-r1.

neoice commented 7 years ago 
% git --version
git version 2.11.0

if it's a non-issue, close it out. maybe someone else using the stable LNP will be helped by this thread :)