BenLubar / nodebb-plugin-import-discourse

5 stars 3 forks source link

few notes after eyeballing the source. #3

Closed akhoury closed 8 years ago

akhoury commented 8 years ago
  1. unlike _timestamp and _edited, topic._deleted and post._deleted are NOT timestamps, either 1 or 0, although I would like them to be, maybe we can request that from the core nodebb team, it kinda makes more sense actually.
  2. (this one is my fault, I should have documented this better, it is now) but in getPaginatedVotes, you shouldn't need to include vote._tid AND vote._pid, either or; use _tid when the Like occured on the "main-post" of the topic (the importer will find the new topic.mainPid using the old _tid), and use _pid when it's on any other post within a topic. (also fixed a major bug in votes in the core import plugin, so you should update to latest)
  3. (also undocumented till now) in getPaginatedPosts - you should also include post._toPid, which is the post_id which was replied to. NodeBB keeps track of these are well.