search

BenMaruchu / public-web

1 stars 3 forks source link

fix #2: removed aliases and added full path to the components #11

Closed mkumbobeaty closed 6 years ago

BenMaruchu commented 6 years ago

@mkumbobeaty

Can you ignore remove and ignore .idea directory in your pull request. That is editor specific configurations should not being tracked by git

mkumbobeaty commented 6 years ago

On Wed, 30 May 2018 at 22:41, Benson Maruchu notifications@github.com wrote:

@BenMaruchu requested changes on this pull request.

Nice Work! But you should also clean up webpack config for production

  • Remove aliases
  • Make sure the application compiles and runs in production

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BenMaruchu/public-web/pull/11#pullrequestreview-124562317, or mute the thread https://github.com/notifications/unsubscribe-auth/AT2pXVVkWzzM2CLC4Olbe2ejfDliv3vsks5t3vXggaJpZM4UT3tH .

Oky i will