Now uses shlex to split commands (to avoid substring splitting)

BenMatteson / CS410_Agile_Group2

CS410 Agile Practice Project - FTP Client

0 stars 2 forks source link

Now uses shlex to split commands (to avoid substring splitting) #62

Open eddiekelleypdx opened 5 years ago

eddiekelleypdx commented 5 years ago

shlex.split() is used in place of the string split() method to avoid splitting substrings (e.g., ls "path with spaces in the name") Closes #52

[ ] When using properly-quoted paths/arguments that contain spaces, the SFTP client will not split substrings incorrectly
[ ] Commands that have trailing whitespace will be 'trimmed'

eddiekelleypdx commented 5 years ago

I don't think that I'll get any unit tests written for this before the demo (since all of our unit / integration tests use the SFTPClient class only - none of them actually test SFPCLI), but will do a little investigating now...

eddiekelleypdx commented 5 years ago

OK, I guess that I was able to get something thrown together to test this... The unit tests that were added test additional stuff (help, quit, etc.) as well, but the SFTPCLI object's __init__ method does some calls to print, which clutters the terminal during testing.

BenMatteson commented 5 years ago

this crashes if you just push enter without typing anything

eddiekelleypdx commented 5 years ago

Good catch on the empty command execution exception... I've pushed a fix for that, as well as a couple of other unit tests that may or may not be helpful.