search

BenPortner / js_family_tree

An interactive family tree visualization using d3-dag
GNU General Public License v3.0
70 stars 30 forks source link

"Maximum call stack exceeded" error #13

Open biga507 opened 1 year ago

biga507 commented 1 year ago

Ben, Thanks for the work on this family tree it's much appreciated. I've been building my own family tree using your software. It goes back 7 generations. However, I have stumbled on a bug with the code that specifically relates to inter family marriages. I have a situation where two first cousins have married and so have a union between them. When I initially expand the nodes it displays correctly. When I collapse the node and attempt to re-expand the link. The screen just freezes for about 10 seconds. When I then attempt to expand any other nodes i get the same behaviour. I've included chrome development mode screenshots that highlight the issue and offending code. Thanks again, Anthony 1 2 3

BenPortner commented 1 year ago

Hi @biga507,

Thanks for using js_family_tree! I am happy to see that you employ it for your own project.

I tried to re-create the error you describe, but in my version everything works fine (cousins marry and have one child, repeated collapsing and expanding of this connection yields no error, data attached). Could you perhaps provide me with your data.js (just rename it to .txt and attach it to your message) so that I can dig deeper? Also, please let me know, which version of js_family_tree you are using.

Thank you and sorry for the inconvenience. Ben married_cousins.txt

biga507 commented 1 year ago

Thanks Ben. I’ve attached a zip file for you to peruse. Regards, Anthony

On 29 Mar 2023, at 07:17 am, Benjamin W. Portner @. @.>> wrote:

Hi @biga507 https://github.com/biga507,

Thanks for using js_family_tree! I am happy to see that you employ it for your own project.

I tried to re-create the error you describe, but in my version everything works fine (cousins marry and have one child, repeated collapsing and expanding of this connection yields no error, data attached). Could you perhaps provide me with your data.js (just rename it to .txt and attach it to your message) so that I can dig deeper? Also, please let me know, which version of js_family_tree you are using.

Thank you and sorry for the inconvenience. Ben married_cousins.txt https://github.com/BenPortner/js_family_tree/files/11093813/married_cousins.txt — Reply to this email directly, view it on GitHub https://github.com/BenPortner/js_family_tree/issues/13#issuecomment-1487539182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOAAFM5JLGU7Q5YLYEPCEDW6NBN7ANCNFSM6AAAAAAUWEBJFI. You are receiving this because you were mentioned.

BenPortner commented 1 year ago

@biga507 Unfortunately, I do not see a zip file attached to your last response. Can you try again (perhaps attaching while answering via email does not work)?

biga507 commented 1 year ago

Sure, I’ll try again

On 1 Apr 2023, at 10:28 pm, Benjamin W. Portner @.**@.>> wrote:

@biga507https://github.com/biga507 Unfortunately, I do not see a zip file attached to your last response. Can you try again (perhaps attaching while answering via email does not work)?

— Reply to this email directly, view it on GitHubhttps://github.com/BenPortner/js_family_tree/issues/13#issuecomment-1492943988, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOAAFKXV3UZ5GDNU4EUNC3W7AGPPANCNFSM6AAAAAAUWEBJFI. You are receiving this because you were mentioned.Message ID: @.***>

BenPortner commented 1 year ago

@biga507 Still nothing. Please make sure you can see the attachment in GitHub.

biga507 commented 1 year ago

I'll try again Modified for Ben Portner (2023-03-29).zip Looks ok to me

BenPortner commented 1 year ago

Hi @biga507,

thanks for the file. I could download it now. However, I cannot reproduce the error you describe. I click on Filippo, Filippo, Vincenzo, Pasquale, Domenica. At this point the link between Domenica and Antonio becomes visible. Nothing freezes. If I click on Domenica again, their children and the link to Antonio disappear, as expected. I can repeat this as often as I want. I tested this in the newest Chrome browser version (111.0.5563.147). Can you try the same order on your computer in Chrome and let me know if it crashes? Otherwise, please let me know which click order exactly causes the error.

Thanks. Ben

biga507 commented 1 year ago

Ben. Thanks for this, I’ll have a look to determine the sequence that causes the issue. Cheers Anthony

On 1 Apr 2023, at 10:51 pm, Benjamin W. Portner @.***> wrote:

Hi @biga507 https://github.com/biga507,

thanks for the file. I could download it now. However, I cannot reproduce the error you describe. I click on Filippo, Filippo, Vincenzo, Pasquale, Domenica. At this point the link between Domenica and Antonio becomes visible. Nothing freezes. If I click on Domenica again, their children and the link to Antonio disappear, as expected. I can repeat this as often as I want. I tested this in the newest Chrome browser version (111.0.5563.147). Can you try the same order on your computer in Chrome and let me know if it crashes? Otherwise, please let me know which click order exactly causes the error.

Thanks. Ben

— Reply to this email directly, view it on GitHub https://github.com/BenPortner/js_family_tree/issues/13#issuecomment-1492948014, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOAAFILFUHME5S6R2MGLVTW7AJFZANCNFSM6AAAAAAUWEBJFI. You are receiving this because you were mentioned.