BenPortner
commented
2 years ago Hi @djBirdman,
First off, sorry that it took me so long to get back to you! Unfortunately, js_family_tree is only a side project for me so I don't get to spend as much time on it as I would like. I hope you are still willing to work on this together!
Second off: Thank you so much for pouring so much time into issue #4! I had a look at your code and I can tell that it was a lot of work! I really appreciate your effort.
Now, my comments on the PR:
- GoT data 1d5709f4e9fdc9d93c5aa42e58b9067e04674c10: Love it! Will use this for the main example on the start page. Right now I am working on a more detailed example section. Will make the change as soon as this is done.
- Sort section 4ffcf81238ad4f3f7b05cca66b8da48e9b0e0d59: Super impressive work! However, I feel like node and layer sorting algorithms should be part of d3-dag, rather than js_family_tree. We should discuss including a generalized version of your algorithm (with arbitrary fields to be used for ranking) in d3-dag. Could you open an issue in https://github.com/erikbrinkman/d3-dag to get the process started?
djBirdman
Might not be the nicest layout (I'll try and work on improving that), but the ordering is correct. This also handles multiple unions per person, adding a unionyear in the data for ordering. I also decided to compile the data file for the Stark family tree from Game of Thrones (not a fan, but a few other d3 tree examples have used parts of it). I suggest using this bigger tree to see what the d3-dag does by itself