search

BenPru / luxtronik

Luxtronik integration for Home Assistant
MIT License
74 stars 28 forks source link

2023.9.12-Alpha-Core-Preview: wrong state-class for "energy" device-class #130

Closed AJediIAm closed 11 months ago

AJediIAm commented 1 year ago

I got the following warning: image

Looking into https://developers.home-assistant.io/docs/core/entity/sensor/, I have some doubts about the energy device class. Although it is energy output, it is heat energy and not electrical energy which often confuses people. Changing the state class from "measurement" to "total increasing" is the easiest fix.

image

Kars-de-Jong commented 1 year ago

That fix is wrong, sorry. This is a power measurement (instantaneous heat output in W). The correct fix is to change device_class to SensorDeviceClass.POWER, and leave the rest as it is.

AJediIAm commented 1 year ago

I think you are correct. I found a reference to parameter 257 here which agrees with power as the class: https://community.openhab.org/t/luxtronikheatpump-finding-the-currently-drawn-power/121605/10

BenPru commented 1 year ago

Is this fixed?

rhammen commented 11 months ago

Is this fixed?

I did not see these errors anymore, so looks fixed to me.