BenPru / luxtronik

Luxtronik integration for Home Assistant
MIT License
66 stars 23 forks source link

Warnings related to visibilities.Unknown_Parameter_357 #186

Open rhammen opened 8 months ago

rhammen commented 8 months ago

Running 2023.11.1-Beta, I see the following 2 warnings in the logs:

This error originated from a custom integration.

Logger: custom_components.luxtronik2
Source: custom_components/luxtronik2/coordinator.py:344
Integration: Luxtronik
First occurred: 22:55:22 (1 occurrences)
Last logged: 22:55:22

Could not load visibility visibilities.Unknown_Parameter_357
This error originated from a custom integration.

Logger: Luxtronik.Visibilities
Source: custom_components/luxtronik2/coordinator.py:427
Integration: Luxtronik
First occurred: 22:55:22 (1 occurrences)
Last logged: 22:55:22

Visibility 'Unknown_Parameter_357' not found
rhammen commented 8 months ago

I downloaded my diagnostics file, and checked the list of visibilties at the end of it. There is no Unknown_parameter_357 mentioned in the visbilities dict. Last entry of my visibilties dict is: "354 Unknown_Visibility_354 ": "None"

Firmware version 3.79.

BenPru commented 8 months ago

What is your installed pypi luxtronik version? Is it 0.3.14?

rhammen commented 8 months ago

What is your installed pypi luxtronik version? Is it 0.3.14?

yes it's 0.3.14

BenPru commented 8 months ago

@rhammen Very strange. Look in the 0.3.14 source: 357 doesn't exist: L367 And unknown Visibilities are create as f"UnknownParameter{index}"

Why is it different in your environment? Please provide a diag file in this issue.

rhammen commented 8 months ago

As far as I can tell, the luxtronik library only creates unknown visibilties if they are reported by the heatpump. And as stated in a previous post: my firmware version is 3.79 My hypothesis is that this visibility.Unknown_Parameter_357 has been added in a firmware version after 3.79. My heatpump therefore doesn't report it, and it is not created by the luxtronik library.

You could add another firmware check on adding this visibilties, But maybe it is better (more generic) to check if the parameter/visibility is reported by the heatpump before adding. That way if more such parameters/visibilities are added in the future, we don't have this issue every time.

Below my diagnostics file.

config_entry-luxtronik2-2890470443fa9886c6a2d3acc8261929.json.txt

BenPru commented 8 months ago

I'm planing to go away from Bounis pypi Bouni/python-luxtronik as the releases are to slow. And using only one Enum with the direkt IDs from Luxtronik Firmware. But it takes time... At the moment it looks for me that it should only generate a warning. I try to test it in the next days.

BenPru commented 7 months ago

Yes it is "just" a warning and a wrong enabled sensor. I change this behave in the new code.