BenPru / luxtronik

Luxtronik integration for Home Assistant
MIT License
66 stars 23 forks source link

Add Missing Sensors (Outdoor Temperature, flow in/out temperature) #243

Closed Albert994 closed 4 months ago

Albert994 commented 4 months ago

Hello,

I updated from the 2023.03 version. I miss some sensors. Could you please add them. (The sensor circulation_pump_heating I found in the list of deactivated sensors, the others unfortunately not):

Thanks Albert

BenPru commented 4 months ago

Please ensure the latest beta integration if you use HA 2023.8 or higher.

Albert994 commented 4 months ago

I have selected yesterday the main branch. That should be the latest version, or?

BenPru commented 4 months ago

Yes

Albert994 commented 4 months ago

I found the issue. The root cause is the following error: 2024-02-27 10:50:53.272 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 521, in async_add_entities tasks = [ ^ File "/config/custom_components/luxtronik2/sensor.py", line 53, in if coordinator.entity_active(description) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/config/custom_components/luxtronik2/coordinator.py", line 353, in entity_active

self.firmware_version_minor # noqa: W503 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/config/custom_components/luxtronik2/coordinator.py", line 322, in firmware_version_minor return int(ver.split(".")[1]) ^^^^^^^^^^^^^^^^^^^^^^ ValueError: invalid literal for int() with base 10: '62B'

My miner version of the firmware is 62B. This cannot be converter to a int.

When I replace this return statement by a fixed number the issue is solved and many more sensors are available.

@BenPru: is it possible to fix this?

BenPru commented 4 months ago

@Albert994 Please try now the main branch.

Albert994 commented 4 months ago

@BenPru : Works with the fix. Thanks!