search

BenSampo / laravel-enum

Simple, extensible and powerful enumeration implementation for Laravel.
https://sampo.co.uk/blog/using-enums-in-laravel
MIT License
2k stars 164 forks source link

Enum method docblock: static vs self #284

Closed wimski closed 2 years ago

wimski commented 2 years ago

Wouldn't it be more accurate to write:

@method static self METHOD_NAME()

...instead of:

@method static static METHOD_NAME()

This would only need a change here: https://github.com/BenSampo/laravel-enum/blob/76faf8cd638980883f0c0e1afdaa552ecef972a1/src/Commands/EnumAnnotateCommand.php#L57

spawnia commented 2 years ago

It is actually less accurate if you are using inheritance, see https://github.com/BenSampo/laravel-enum/pull/285.