Open Grey41 opened 2 years ago
We use a library to keep a 16:9 aspect ratio on the display window: https://github.com/antonfisher/electron-aspect-ratio-browser-window
Evidently this doesn't seem to work on Windows. Perhaps the best thing to do for now is to not keep the aspect ratio on Windows and instead only set this up on darwin.
There also seems to have been improvements in this area such as in https://github.com/electron/electron/pull/26941 which might mean we implement our own version of aspect ratio using these updated methods. The code from the library we use is actually very minimal.
As I don't have a Windows machine though this would be difficult for me to test so any help would be appreciated.
Packages & versions
Media v0.11.0
Describe the bug
I attempted to compile and test Library Media for Windows. When I tried to resize the media display window, it shot off the screen and became very small. Unfortunately, this would make it unusable for a Windows machine.
Reproduction steps
Expected behavior
I expected the window to resize smoothly, just like any other window.