search

BenThelen / python-refprop

Python (3.x & 2.x) API for NIST Standard Reference Database 23 (a.k.a. Refprop) on Linux and Windows
Other
43 stars 25 forks source link

[bug] in wmol function definition #5

Closed kevinholst closed 10 years ago

kevinholst commented 10 years ago 
    if platform.system() == u'Linux':
        _rp.wmoldll_(_x,
                    ctypes.byref(_wmix))
    elif platform.system() == u'Windows':
        _rp.WMOLdll(_x,
                        ctypes.byref(_wmix))

I believe the Linux function should be:

        _rp.wmol_(_x,

Thanks so much for this great piece of coding!

BenThelen commented 10 years ago

Yes and No, Yes to be consistence with the other API calls No, because the Nist fortran code for this function does not return the wmix value. As such the python API cannot (technically it can) obtain this. Hence the code utilise the windows dll function.

thanks for the update