search

BenWestgate / Bails

Bails is a Bitcoin solution protecting against surveillance, censorship, and confiscation. It installs Bitcoin Core on the encrypted Persistent Storage of Tails, creates and recovers Bitcoin Core wallets from Codex32 (BIP93) seed backups, and creates backup Bails USB sticks and shareable blank Bails USB sticks. Learn more in README.md.
MIT License
40 stars 7 forks source link

Value set for prune is not the highest value that would display green in -choosedatadir dialog. #36

Closed BenWestgate closed 1 month ago

BenWestgate commented 12 months ago

This is likely due to the off by one, precision or rounding error in #35 and if not due to that, is from subtracting (10 + assumed chainstate) GiB from my available storage rather than 10 + 7 GB. Solve #35 first because it is simpler, then fix this dependant one.

github-actions[bot] commented 3 months ago

Stale issue message

BenWestgate commented 3 months ago

This will be fixed by removing the bails dialog and using Bitcoin Core's welcome screen. By assigning HOME+=/Persistent the default location will be the correct one.

BenWestgate commented 3 months ago

This is also a duplicate of #35.

BenWestgate commented 1 month ago

Despite switching to the Welcome screen, there's still a calculation error.

On a USB Stick with 50182044 1K blocks available, our math suggested using 30 GB as the initial prune but 31 GB would have not displayed a warning.

The actual prune value sent by the command line was -prune=28518 which is 29903290368 bytes so this was very close to having exceeded 30 GB which would have made the value displayed round up to 31 GB.

BenWestgate commented 1 month ago

The Chainstate and 10 GB buffer (20 GB total currently) should be subtracted as 10^9 not 2^30, this would have displayed the correct slightly higher value.