BenWestgate / Bails

Bails is a Bitcoin solution protecting against surveillance, censorship, and confiscation. It installs Bitcoin Core to Tails encrypted Persistent Storage, creates and recovers Bitcoin Core wallets from Codex32 (BIP93) seed backups, and creates backup Bails USB sticks and shareable blank Bails USB sticks. Learn more in README.md.
MIT License
46 stars 9 forks source link

Use constants for Bitcoin Core domains and improve readability #94

Closed epiccurious closed 6 months ago

epiccurious commented 8 months ago

PR is now properly merging into 73-dont-hardcode-urls rather than master.

epiccurious commented 8 months ago

Next step is to verify if the Bitcoin Core tor service is running right now.

epiccurious commented 8 months ago

Converted to draft until I find and test the correct .onion address.

BenWestgate commented 8 months ago

Next step is to verify if the Bitcoin Core tor service is running right now.

It's not:

https://github.com/bitcoin-core/bitcoincore.org/issues/985

Lets swap the order of the attempts until the issue closes.

epiccurious commented 8 months ago

Lets swap the order of the attempts until the issue closes.

Resolved with https://github.com/BenWestgate/Bails/pull/94/commits/8ac8b39079e727460c90ab57c0b9157f521c8aea

epiccurious commented 6 months ago

Passed my manual testing.

Due to rebasing against master, shellcheck is now being enforced.

Will address lint issues then re-test.

epiccurious commented 6 months ago

Rebased and resolved conflicts.

epiccurious commented 6 months ago

Fixed lint issues. Need to retest and resolve open review comments.