BenWildeman / vscode-tabulous

Adds tabs for each terminal process to the status bar
https://marketplace.visualstudio.com/items?itemName=bwildeman.tabulous
MIT License
12 stars 2 forks source link

Status bar buttons opening incorrect terminals #25

Open Snowcola opened 4 years ago

Snowcola commented 4 years ago

[VS Code version: 1.50.1] When I'm clicking on the terminal buttons in the status bar there seems to be an off by 1 error and it either opens the terminal to the right or if you click on the last terminal on the rights it wraps to the start and opens the first one.

BenWildeman commented 4 years ago

Yep, I personally see this from time to time myself

ghost commented 4 years ago

Came here to post the same bug. Here is an observation I have seen.

If I close VS Code down with a terminal window open (from tabulous), and re-open VS Code, the same terminal window will be breifly open and then close right away. On the status bar, it will show I have a tabulous terminal open (i dont, it was closed on VS Code startup). Here I can observe the now "off by 1" error.

If I close my terminal windows down, and then close VS Code. Upon reopening, I notice that there not not a tabulous tab open, and the off by one error does not exist.

Hopefully that helps!

rjrudin commented 3 years ago

Great plugin, but I'm able to consistently reproduce the same behavior from a clean start:

  1. Install the plugin
  2. Add a couple default terminals to workspace.json (example below)
  3. Run "Reload default terminals" action

The two terminals appear in the status bar correctly. But if I click on "term1", "term2" opens up, and vice versa.

Content in workspace.json file:

"tabulous.defaultTerminals": [
    {
        "name": "term1",                
    },
    {
        "name": "term2"
    }
]
rjrudin commented 3 years ago

Little more info - if I have 3 terminals, then the specific problem is:

Note that this only happens based on default terminals. If I then manually add new terminals, the buttons for them work correctly.

One more item - if I then manually add a new terminal, the buttons now work properly. So the problem seems to be limited to when I start VSCode and/or reload default terminals.