BenWildeman / vscode-tabulous

Adds tabs for each terminal process to the status bar
https://marketplace.visualstudio.com/items?itemName=bwildeman.tabulous
MIT License
12 stars 2 forks source link

Statusbar buttons index issue #3

Closed BenWildeman closed 4 years ago

BenWildeman commented 5 years ago

raised by: @Cirieno https://github.com/BenWildeman/vscode-terminal-tabs/issues/5

(VSCode version 1.29.1) I installed your extension today and just while testing seem to have hit a bug: if I define at least two default terminal buttons (ie [cmd_A] and [cmd_B]) so they both show in the statusbar on load, clicking on [cmd_A] reveals the error "tabulous.showTerminal0 is not a valid command", but clicking on [cmd_B] shows the working terminal for [cmd_A]. Which basically means the indexing has gone wonky at some point. I've fixed it locally by editing showTerminal.js L#8 so that it registers the command tabulous.showTerminal${i+1}, but you may have a more elegant way of fixing this issue? (if you can recreate the bug). Thankyou for your time!