search

BenWildeman / vscode-tabulous

Adds tabs for each terminal process to the status bar
https://marketplace.visualstudio.com/items?itemName=bwildeman.tabulous
MIT License
12 stars 2 forks source link

Patch/default terminal path resolution #7

Closed Samuel-B-D closed 4 years ago

Samuel-B-D commented 4 years ago

Implemented a more robust and flexible way of specifying the cwd of default terminals, since I had issue with those in a multi-root workspace configuration.

BenWildeman commented 4 years ago

I've tested this. personally, I use relative paths within my defaultTerminals, but with your change, this breaks image

Samuel-B-D commented 4 years ago

I've tested this. personally, I use relative paths within my defaultTerminals, but with your change, this breaks image

Are you using a workspace or just an opened folder? Also what's the path of the folder vs the directory in your default terminal? I assume you opened the folder c:\code\work and the directory is directory: "packages\pz-api"?

BenWildeman commented 4 years ago

I see what you're trying to accomplish. mind if I take this over and make it more robust?

Samuel-B-D commented 4 years ago

I have no objection. I just wanted to fix the issue with multi-root workspace (you can't use relative path with the current implementation, because it's relative to... something, which is undeterministic (sometime it starts from the directory in which your workplace is, sometime the first workspace folder...))

BenWildeman commented 4 years ago

@kazelone would you like to take a look at #9 and see if this is sufficient

Samuel-B-D commented 4 years ago

@BenWildeman Done, I commented there.