search

Benchmarking-Initiative / Benchmark-Models-PEtab

A collection of mathematical models with experimental data in the PEtab format as benchmark problems in order to evaluate new and existing methodologies for data-based modelling
BSD 3-Clause "New" or "Revised" License
26 stars 14 forks source link

Simplify Beer, fixes #114 #134

Closed FFroehlich closed 2 years ago

FFroehlich commented 2 years ago

Moves definition of experimental specific conditions from model to experimental table

elbaraim commented 2 years ago

Hi @LeonardSchmiester have you originally implemented this model? I could not find this in the closed issues. If that is the case, would you be able to have a quick look at Fabi's fixes since you would be more familiar with the model?

(If you did not implement this model, could you please point the person here?)

LeonardSchmiester commented 2 years ago

I don't remember who worked on this model. Might have been me during the first hackathon. From what I can tell, it looks correct. I think when we first implemented the model we had to introduce these switch parameters, because PEtab could not handle it better back then. But this is of course much nicer now. Simulations also look fine, so I think it can be merged. Thanks for the work @FFroehlich

dilpath commented 2 years ago

Thanks for the nice simplification! Small issue: in the simulated data, a parameter ID is used as a condition ID (Bacmax_typeIDwt_ExpID4).