search

Benchmarking-Initiative / Benchmark-Models-PEtab

A collection of mathematical models with experimental data in the PEtab format as benchmark problems in order to evaluate new and existing methodologies for data-based modelling
BSD 3-Clause "New" or "Revised" License
26 stars 14 forks source link

Fix Bachmann_MSB2011 #136

Closed FFroehlich closed 2 years ago

elbaraim commented 2 years ago

Hi @FFroehlich why were the uniform priors added to this model?

stephanmg commented 2 years ago

@elbaraim I think that this is related to issue #135 - the "original" d2d model contained these priors.

elbaraim commented 2 years ago

@elbaraim I think that this is related to issue #135 - the "original" d2d model contained these priors.

Hi @stephanmg thanks for linking the issue! However this only would explain the normal prior :)

FFroehlich commented 2 years ago

Hi @FFroehlich why were the uniform priors added to this model?

I wasn't sure whether I could just leave those rows empty, is that valid PEtab?

elbaraim commented 2 years ago

I wasn't sure whether I could just leave those rows empty, is that valid PEtab?

I guess so 🙈 since this other model is in the current benchmark collection (therefore undergo all checks) https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/blob/master/Benchmark-Models/Raimundez_PCB2020/parameters_Raimundez_PCB2020.tsv 😄

FFroehlich commented 2 years ago

I wasn't sure whether I could just leave those rows empty, is that valid PEtab?

I guess so 🙈 since this other model is in the current benchmark collection (therefore undergo all checks) https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/blob/master/Benchmark-Models/Raimundez_PCB2020/parameters_Raimundez_PCB2020.tsv 😄

fixed!