add pre/postequilibration info, count piecewise in parameters as events

Benchmarking-Initiative / Benchmark-Models-PEtab

A collection of mathematical models with experimental data in the PEtab format as benchmark problems in order to evaluate new and existing methodologies for data-based modelling

BSD 3-Clause "New" or "Revised" License

26 stars 14 forks source link

add pre/postequilibration info, count piecewise in parameters as events #146

Closed plakrisenko closed 2 years ago

dilpath commented 2 years ago

Thanks! Could you please update the table in the README to include the new information? A markdown table can be generated by calling the script with the --markdown flag.

https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/blob/0a76a982b513c07efad7d4ffa8e3200745c9d68b/Benchmark-Models/model_info.py#L106

dilpath commented 2 years ago

Fine as is but

'preequilibration' could be a count of the number of unique values in the preequilibration column of the measurement df, similarly
'postequilibration' could be a count of the number of unique preequilibration+simulation condition groups that have an inf timepoint.

Might be easy with this method https://github.com/PEtab-dev/libpetab-python/blob/master/petab/measurements.py#L111