search

Benchmarking-Initiative / Benchmark-Models-PEtab

A collection of mathematical models with experimental data in the PEtab format as benchmark problems in order to evaluate new and existing methodologies for data-based modelling
BSD 3-Clause "New" or "Revised" License
26 stars 14 forks source link

Fix model IDs, names, and missing references #153

Closed dilpath closed 2 years ago

dilpath commented 2 years ago

closes #147 closes #150

elbaraim commented 2 years ago

some models have some arFramework3 annotations from d2d that have been added in this PR, e.g. Okuonghae_ChaosSolitonsFractals2020, @dilpath do you know why?

dilpath commented 2 years ago

some models have some arFramework3 annotations from d2d that have been added in this PR, e.g. Okuonghae_ChaosSolitonsFractals2020, @dilpath do you know why?

Thanks, was copied from another model, now renamed to #benchmark_models_petab.

elbaraim commented 2 years ago

@dilpath some models have metaid but for some was removed, could you check this to make it consistent?

some models have some arFramework3 annotations from d2d that have been added in this PR, e.g. Okuonghae_ChaosSolitonsFractals2020, @dilpath do you know why?

Thanks, was copied from another model, now renamed to #benchmark_models_petab.

Thanks! SalazarCavazos_MBoC2020 model still contains arFramework3 as annotation :)

Additionally, I found that some models contain metaid while some others not, and for example for Oliveira it was removed

dilpath commented 2 years ago

@dilpath some models have metaid but for some was removed, could you check this to make it consistent?

some models have some arFramework3 annotations from d2d that have been added in this PR, e.g. Okuonghae_ChaosSolitonsFractals2020, @dilpath do you know why?

Thanks, was copied from another model, now renamed to #benchmark_models_petab.

Thanks! SalazarCavazos_MBoC2020 model still contains arFramework3 as annotation :)

Additionally, I found that some models contain metaid while some others not, and for example for Oliveira it was removed

Now restored to the original metaid, with rdf:about set to its appropriate (the same) value. Also opened #155 to address this.