search

Benchmarking-Initiative / Benchmark-Models-PEtab

A collection of mathematical models with experimental data in the PEtab format as benchmark problems in order to evaluate new and existing methodologies for data-based modelling
BSD 3-Clause "New" or "Revised" License
26 stars 14 forks source link

Added Froehlich Cell Systems 2018 model. Closes #78 #161

Closed LeonardSchmiester closed 2 years ago

FFroehlich commented 2 years ago

Really hard to judge for me as the files are so gigantic. How was this validated that implementation is correct?

stephanmg commented 2 years ago

I merely remember by private communication with @LeonardSchmiester that he did validate the simulations of this PEtab model prior to opening the PR. I myself didn't do further validation, just a quick sanity check that I can import and run the model with the parameter estimation pipeline.

dilpath commented 2 years ago

Thanks to @plakrisenko for checking. Compared to the original implementation, the following files are the same or negligibly different

The parameters table has new nominal values, which presumably were both the output of optimization and used to produce the simulated data.

So I guess this implementation is "corrrect", in that it matches the original implementation.