search

Bencotti / pe

0 stars 0 forks source link

Quizing first subject despite wrong input #4

Open Bencotti opened 4 years ago

Bencotti commented 4 years ago

Error command: Quiz

Error payload: quiz s/ 1

Command continues to run the first subject even though the wrong input was given. Program manages to catch the error for space but not when an actual non blank argument is given. The number of spaces can be increased or decreased to manipulate the display of the quiz command.

3.png

nus-pe-bot commented 4 years ago

Team's Response

This is an intended feature to remove whitespaces, so as to be user friendly. If the user types in "quiz s/       1", he is evidently intending to start a quiz for the 1st Subject. This is why we decided to accept that input even with so many extra whitespaces. Not accepting whitespaces would also penalise the user if he/she accidentally puts extra whitespaces, forcing him/her to retype the entire command, which is not a user-friendly approach.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the explanation, but I have to disagree with the team's response. I do not believe it is "evident" when a user tries to insert so many spaces into the argument.

15.png

It is hard to believe that the above error is a result of accidental presses.

If allowing whitespaces was meant to be "userfriendly" in your context, shouldn't this be approved as well?

17.png

The distance between those two inputs were only one character.

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]