search

BendJS / bend-community-site

Community website for all tech sectors in Bend. #BendHacktoberfest
1 stars 16 forks source link

Create Clear Path to Merging #19

Open russtaylor opened 4 years ago

russtaylor commented 4 years ago

I think it'd be beneficial for us to determine a clear path to getting PRs merged. I know a lot of us want to contribute (and want to accomplish things quickly, so we can make a lot of progress this month), but right now I'm not sure what the criteria are for getting a PR merged (or even a clear idea of who can merge them).

I personally think that it would be good for us to add a number of contributors to this repo, and perhaps specify a threshold for the number of approvals required to merge a pull request into master.

What do all of you think?

ctsstc commented 4 years ago

We should definitely enable the PRs required for merging to master & CI passing I think.

We can add a .GIT/CONTRIBUTING.md to the repo, I think if we have the right CIs and preventions in place that they will be the most important, but we should still have something on the README.md that states that code should be tested & passing.

I think at least 2 reviews would be a good check to have in place. There's definitely times though where 1 review should be sufficient for trivial changes. For larger decisions we should involve some level of "stakeholders" -- people who are closely connected that are driving the direction of the site to meet the needs.

Might be related to #3 a scosche.

russtaylor commented 4 years ago

That sounds like an excellent idea! I think a contribution guide and a set of guidance on merging would be appropriate.