Initial Calendar Commit

BendJS / bend-community-site

Community website for all tech sectors in Bend. #BendHacktoberfest

1 stars 16 forks source link

Initial Calendar Commit #26

Open markpernotto opened 5 years ago

markpernotto commented 5 years ago

This initial PR provides a basic react-based calendar that we can work with; allows for the inclusion of multiple event endpoints, is extensible with regard to stylings, and offers some basic tools we can begin working with.

Updating with screenshot per @ctsstc request

Also added Link in header component && updated styling for readability.

Adds moment && react-big-calendar dependencies.

ctsstc commented 5 years ago

Looks like the snapshot needs to be updated to get tests passing.

Could you throw a screenshot in the main PR -- not necessary but would be nice :)

Awesome work! Thanks

ctsstc commented 5 years ago

@kcloud99 @russtaylor maybe we want to disable test snapshots? Do you guys normally use them? I know some people hate them and find them to be a pain and useless¿

markpernotto commented 5 years ago

A few other notes I should probably mention for future development:

In this initial commit, Events are passed in via an array of objects from a file: fakeData.js. This is mostly from react-big-calendar's examples, but I've added a few other key/val pairs to flesh out a few of the ways we could use this board to represent varying calendars.

A selected function has been implemented to capture the clicked on event. Currently, it just writes the object selected to the console.

This Calendar module we're using can only be implemented through either moment or globalize. I went with the former because I'm more familiar with the library as a whole, but I don't actually have a preference.

markpernotto commented 5 years ago

Updated snapshot - or at least attempted to.

ctsstc commented 5 years ago

Hrmm odd,, it failed, did you try running the command with npx to scope it to the project's version. Although if there's a newer version maybe we should look into using it, but that also sounds like it could be a nightmare -- at least the project is still young to make these choices.

markpernotto commented 5 years ago

@ctsstc yeah, I did that wrong. Reverting previous commit and running yarn test. Just a moment

markpernotto commented 5 years ago

@ctsstc I think that did it. Thanks for the help there.

russtaylor commented 5 years ago

@ctsstc I don't know about keeping the snapshots, I personally haven't used them before. It seems like they're more trouble than they're worth, but that's just on the surface.

jweinsteincbt commented 5 years ago

👍 🚢 :shipit: