Bendr0id / xmrigCC

RandomX, CryptoNight, Argon2 and GhostRider CPU/GPU miner with Command&Control (CC) Server and Monitoring
GNU General Public License v3.0
312 stars 108 forks source link

update sorting "Group by Algo" #289

Closed MrCook1es closed 4 years ago

MrCook1es commented 4 years ago

Hi, I think it would be more useful and convenient that the "Group by Algo" sorting was done entirely by algorithm and not by the A-Z as it is now:

immagine

a visualization of this type is more practical: immagine

Bendr0id commented 4 years ago

Changed in master. Just fetch the latest index.html and copy to your server.

Please test if thats more the expected behavior.

MrCook1es commented 4 years ago

I confirm that it works correctly without errors.

electroape commented 4 years ago

So how to disable grouping now ?

FranzDE commented 4 years ago

So how to disable grouping now ?

Di you mean a sort like this

Switchable to the old style like 1 year ago? (All together)

electroape commented 4 years ago

Nope, how to disable grouping altogether, there was a switch in previous version.

MrCook1es commented 4 years ago

Nope, how to disable grouping altogether, there was a switch in previous version.

what result would you like to get? I do not understand.

if the switch is replaced. maintained the current visualization by algo, what kind of sorting would you like? please explain

electroape commented 4 years ago

There was a switch prior to 2.2.2, right below "Hide offline miners" and "Notify when miner went offline", flicking it disabled grouping by algo, now there's not.

MrCook1es commented 4 years ago

There was a switch prior to 2.2.2, right below "Hide offline miners" and "Notify when miner went offline", flicking it disabled grouping by algo, now there's not.

I know that there was a switch. I'm asking you things must happen if you press it. what visualizations would you like to alternate?

electroape commented 4 years ago

What you think should happen if you flick "Disable algo grouping' switch ? It disables grouping.

electroape commented 4 years ago

Like, it just sorts by whatever column uses chooses, be it id or hashrate, without grouping altogether, i don't see what's so hard to grasp here. Grouping are useful sometimes, most of the time it's not, at least for me.

Bendr0id commented 4 years ago

Don't see the problem. The sorting still works but it only sorts within the same group which is the expected behavior for most of the users. The old grouping was just broken

electroape commented 4 years ago

Come on ... there was a way to disable grouping in previous version, now there's no way, it's always grouped by algo, which is not always convenient. New sorting withing groups are indeed better but there needs to be a way to disable grouping altogether.

Bendr0id commented 4 years ago

The option was there because the old mechanism was bad. With the new the grouping mechanism a enable/disable wasn't that easy and I'm not a webdev. So if you want the old behavior either use the old index.html from the history, keep the current behavior or feel free to contribute a better implementation with enable/disable feature.

electroape commented 4 years ago

That clears it, i'm no webdev either but i've already reverted to old index.htm

Bendr0id commented 4 years ago

That seems to work. Please check if it behaves like expected

electroape commented 4 years ago

Yep, it works, thanks !

MrCook1es commented 4 years ago

@Bendr0id seems legit! ;)

@uz-spark is the exact same thing that Franz had written

Di you mean a sort like this

Switchable to the old style like 1 year ago? (All together)