search

BenedictBCJJ / pe

0 stars 0 forks source link

Too much information in UML for tab switching #20

Open BenedictBCJJ opened 3 years ago

BenedictBCJJ commented 3 years ago

Too much information given when they could just show from input parser or logic manager onwards, makes everything too small and complicated image.png

nus-pe-bot commented 3 years ago

Team's Response

Thank you for your feedback. The team has reviewed this report and decided that this is not an issue.

Reason

Both UI and Model portions are essential for this diagram.

Elaboration

As per the steps mentioned above the diagram, this portion of the UG provides a walkthrough of how developers can use commands to toggle the tab on the UI.

Screenshot 2021-04-19 at 11.04.07 AM.png

In the sequence diagram, we showcase how a command can be executed to create a CommandResult with the tab parameter. It will then be passed to the UI component MainWindow, which then checks for the tab parameter and updates the DetailsPanel respectively. Hence, we disagree that this sequence diagram is complicated or has too much information.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Yes you can remove parts of your UML from preventing it from being complicated and text being too small. Take a look at AB3 where their UI also performs an action. image.png It is sufficient to not show the UI part and explain it in your implementation.

e.g (add this line) In addition, the CommandResult object can also instruct the Ui to perform a tab switch.

image.png

Or focus on the UI part and not show Command and Command result. Then explain that the cmdResult is changed in commandResult, which in your diagram shows that it triggers toggleTab()

e.g (add this line) LogicManager executes the Command and returns a CommandResult object with a specified tab to display .

image.png