search

BenedictBCJJ / pe

0 stars 0 forks source link

Does not execute when given multiple parameters (theme) #8

Open BenedictBCJJ opened 3 years ago

BenedictBCJJ commented 3 years ago

theme @monokai @pulp should have executed with the second parameter image.png

nus-pe-bot commented 3 years ago

Team's Response

Thank you for your feedback. The team has reviewed this report and decided that this is not an issue.

Reason

This is the intended behaviour.

Elaboration

It is stated in the user guide that the format for theme is theme THEME. Providing 2 tokens with @ prefixed parses the input as one token and searches for the predefined theme monokai @pulp, which does not exist.

Dropping severity

Assuming this is accepted as a bug then it wouldn't even affect the functionality of the application in any way, which should be classified as VeryLow

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: UG clearly states that if a parameter is expected only once, if you specify it multiple time, only the last occurrence will be taken. image.png

The parameter is specified twice and it gives an error instead of taking the last ocurrence.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: The user will expect that the last theme would succeed instead the user would have to delete the previous argument and retype the new argument, this can occur in typos or the sort which can greatly inconvenience the user. e.g theme @monokai @pup -> error -> theme @monokai @pulp -> error -> theme @pulp -> succeed This will inconvenience the user if they decide to want another theme after typing finish the first one or second and so on.