BenedictChannn / pe

0 stars 0 forks source link

Add Income allows additional input #5

Open BenedictChannn opened 8 months ago

BenedictChannn commented 8 months ago

image.png

What if the user accidentally provides a category for the income? It seems that category is only applicable for expenses but the add income command still went through successfully with the addition of a /cat. Although it was ignored, I believe it should be flagged out as an issue. WHat if the user wanted to key in an expense but accidentally misspelled since he/she is typing very fast. If this is not flagged out, then the transaction will be recorded wrongly.

nus-se-script commented 8 months ago

Team's Response

I do not see how can one type a typo from income to expense. When both words are two very different word. And the add income has been made to ignore additional wrong inputs provided by users

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: You do not see it but have you tested it out with different users? Such confusion can happen because this is a CLI application and people that uses it tend to type very quickly. Hence such confusion/ typo will be common when using it. These are some errors that my own group faced when we tested with other users.

Besides that, there is an inherent flaw in the parser when you allow additional parameters to be accepted into the add Income command. Even though it was ignored, an error should have appeared so as to inform the user. Perhaps a message to confirm with the user again on their input would be good as well. This makes your parser more correct and also more robust.