BenedictChannn / pe

0 stars 0 forks source link

Income amount accepted has discrepancy with error message #6

Open BenedictChannn opened 8 months ago

BenedictChannn commented 8 months ago

image.png

When the user first tried to input a negative amount, the error message prompted the user that the accepted amount is between 0.01 to 999999.99 but when the user then proceeds to key in 0.001 as the amount, an amount of $0.00 was allowed to be recorded.

nus-se-script commented 8 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add income command: able to add an income amount of $0 due to more than 2 d.p. bug

I was able to add an income amount that is less than $0.01 by having the amount to be $0.001 perhaps you should have the add parser check the number of decimal places entered in the /amt tag

image.png


[original: nus-cs2113-AY2324S1/pe-interim#106] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

it has been stated clearly in user guide as well as developer guide that users are supposed to input amount of up to 2 decimal places. if users were to input more than 2 decimal places, the program will roundup/round down the value.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** I believe the error here is the discrepancy between your error message and what can be accepted by your application. If your error message clearly states that the application only accepts amount from $0.01, then it should not be able to accept a value of $0.00 at all
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]