search

Benedikt05 / BetterAltay

A server software for Minecraft: Bedrock Edition in PHP
GNU Lesser General Public License v3.0
75 stars 38 forks source link

Glow SignText #170

Closed efor89 closed 2 months ago

efor89 commented 1 year ago

Description

hi can you plz add that we can add glow sign text (not with glow_inc_sak only in code)? its in pmmp5 alredy impliment https://github.com/pmmp/PocketMine-MP/blob/5.0.0-BETA2/src/block/tile/Sign.php

Justification

after the editor was add, the signtext is rly dark and with this we can make it glow. and its rly cool if ba have it.

JoseLuisHD commented 1 year ago

Sure

efor89 commented 1 year ago

ty :)

efor89 commented 1 year ago

can u add plz signColorChangeEvent? that we can chancel the color change and glow change for some plugins plz?

JoseLuisHD commented 1 year ago

https://github.com/Benedikt05/BetterAltay/commit/02bb5f7366fb95a34854602e6b621d75b7bb9b07

efor89 commented 1 year ago

why close?

efor89 commented 1 year ago

without this changes it works axactly same

vp817 commented 1 year ago

without this changes it works axactly same

didnt josi or something add signtextcolorchangeevent or something?

efor89 commented 1 year ago

yes but if u remove all the code with color and glow from ba it change nothing. if u klick on sign with dye the color change only for you and after rejoin the color is gone. with glow its change to glow if you open editormode with glowincsac and after close the editor the glow is gone.

efor89 commented 1 year ago

so in the moment the event do nothing.