search

BeneosBattlemaps / beneos-module

1 stars 2 forks source link

Beneos: MLT Drawing.SHAPE_TYPES.RECTANGLE #146

Closed BeneosBattlemaps closed 3 months ago

BeneosBattlemaps commented 3 months ago

Blair (The creator of Scene packer and other modules) suggestested the following:

  1. There is: Drawing.SHAPE_TYPES.RECTANGLE as a constant to replace the old constants (and prevent needing to just use r everywhere)
  2. if it was worthwhile making one of the actions async it's probably worth making the others async as well

He almost took over MLT and forwareded those hints to us =)

LeRatierBretonnien commented 3 months ago

Fixed ! Point 1 is OK, Point 2 was a debug try, so async has been removed now. Commit done in github.com/LeRatierBretonnien/foundryvtt-multilevel-tokens/