search

Benestar / wikibase.net

Api client for the MediaWiki extension Wikibase
http://wikiba.se/
GNU General Public License v2.0
8 stars 6 forks source link

When is rework going to replace master, what were the plans for rework #5

Open DanielSlater opened 9 years ago

DanielSlater commented 9 years ago

Hi Ahoerstemeier

I've just started looking into this API(have taken a fork and added visual studio project files). Master doesn't work on a lot of items because of missing entity types that are fixed on rework. When were you thinking to push rework back to master? Also what was the plan with rework if you don't mind me asking. I also have some tests I've set up for the project if you want them?

Ahoerstemeier commented 9 years ago

At first I hoped to get my enhancements as well as rework into the original repository by Bene, but he already didn't liked the modified code formatting, and apparently stopped to work on this at all. I kept my master to be close to the original one by Bene to be able to push my changes eventually, but did all further development as well as bugfixing in the rework branch. As I am still new to Git, I am not sure if this is the best practice of using branches with git... I had done some basic rework already, like using enums instead of magic constants or using proper properties, but stopped when it was usable enough for my bot. Since it was quite some time ago I am not sure which were the main remaining problems I saw then - one certainly are datastructure which are writeable but should be read-only. But would be happy to start working on it again in a collaborative way.

DanielSlater commented 9 years ago

I've had a bit of look through your changes on the rework branch, they look pretty reasonable to me. Given that the master branch doesn't currently work lets merge back to master and go from there. I'm happy to put a bit of time into this, beyond getting it working there are a few other API changes I wouldn't mind seeing.

Benestar commented 9 years ago

Hey guys, sorry that I didn't look into this for such a long time but I'm working on the Wikibase software itself and thus didn't have enough time to look into this. I have created a branch v1.x and merged @Ahoerstemeier's bugfixes into that branch. Furthermore, I started a complete rewrite which doesn't use ugly JSON objects internally but is a complete and independent representation of the Wikibase DataModel. Furthermore, I plan to improve API support and of course I will update the library to support all further data types.

I hope I will soon be able to publish a first version of that rewrite as a 2.0 relesae.