search

Benex254 / FastAnime

Your browser anime experience from the terminal
The Unlicense
174 stars 5 forks source link

Episodes list in anilist options #3

Closed SilvioDylan closed 3 months ago

SilvioDylan commented 3 months ago

I've added the ability to play specific episodes through the anime menu. Unfortunately, this doesn't play well with watch history. I.e., if you stop watching an episode in the middle, and switch to another episode, it will start in the middle of that episode. I suggest saving start_time for each episode separately, or at least checking if the episode number matches the one in the watch history before setting start_time.

I also added a conditional at line 357 to prevent updating AniList progress if the user's progress is higher than the currently watched episode. Otherwise, it would set the progress back whenever I went back to a previous episode. I think it would make sense to do the same for watch history (in case we don't save start_time for each episode).

Benex254 commented 3 months ago

I have implemented the episodes feature you requested since i ended up changing and refactoring the codebase heavily and i felt it would be unfair to have you redo it. Though for the other changes i still stand firmly with my decision. However, if you are still not satisfied you can open up another pull request after updating your local git history with the changes and refactoring i have made. Thankyou for your contributions in making FastAnime better.

SilvioDylan commented 3 months ago

No problem! The changes I make are purely for my own needs and with these few adjustments the app meets most of my needs already. Thanks for making this app and good luck with taking it to v1.0!