Benik / LocationPlus

4 stars 2 forks source link

[WoTLK] Continent and level range #3

Closed Iowerth closed 1 year ago

Iowerth commented 1 year ago

Hi. Version 2.68 WoTLK. Maybe I bored you, but i have one more issue. There are: • no continent names (I'm playing not in English, maybe this is a reason, but in Vanilla it was normal) • no level range for zones

Benik commented 1 year ago

Both Level Range and Continent work fine image

Level Range and Continent info are provided by LibTourist. It's used to provide all the info in the tooltip and it's maintained by another author. I'm not sure if the author has localisations for your language but tbh there's never been an issue like that.

Iowerth commented 1 year ago

Here's the thing, understand. I'll check LibTourist. Thank you!

Benik commented 1 year ago

LibTourist is included in Location Plus, you don't have to install it separately. I'm constantly watching if there's a new version.

Benik commented 1 year ago

The only issue I can think of is if there's another addon that includes an outdated LibTourist version and that addon loads before LocationPlus

Iowerth commented 1 year ago

LibTourist is included in Location Plus, you don't have to install it separately. I'm constantly watching if there's a new version.

Your addon has the same version, I checked.

Iowerth commented 1 year ago

The only issue I can think of is if there's another addon that includes an outdated LibTourist version and that addon loads before LocationPlus

Ok, I'll check my Addons folder, thanks.

Iowerth commented 1 year ago

The only issue I can think of is if there's another addon that includes an outdated LibTourist version and that addon loads before LocationPlus

From all my addons only FishingBuddy has lib called LibTouristClassic-1.0. But this addon is disabled on toon where I checked your addon.

Iowerth commented 1 year ago

Here are bugs I got with BugSuck.

1x ...libs\LibTouristClassic-1.0\LibTouristClassic-1.0-90248.lua:912: bad argument #1 to 'pairs' (table expected, got nil)
[string "=[C]"]: in function `pairs'
[string "@ElvUI_LocPlus\libs\LibTouristClassic-1.0\LibTouristClassic-1.0-90248.lua"]:912: in function `CreateLocalizedZoneNameLookups'
[string "@ElvUI_LocPlus\libs\LibTouristClassic-1.0\LibTouristClassic-1.0-90248.lua"]:2414: in main chunk

Locals:
(*temporary) = nil
(*temporary) = "table expected, got nil"
 = <function> defined =[C]:-1

1x ElvUI_LocPlus\libs\LibTouristClassic-1.0-90248\CallbackHandler-1.0-7\CallbackHandler-1.0.xml:1 (null)

1x ElvUI_LocPlus\libs\LibTouristClassic-1.0-90248\lib.xml:1 ElvUI_LocPlus\libs\LibTouristClassic-1.0\CallbackHandler-1.0-7\CallbackHandler-1.0.xml:1 (null)

1x ElvUI_LocPlus\libs\load_libs_wrath.xml:1 ElvUI_LocPlus\libs\LibTouristClassic-1.0-90248\lib.xml:1 ElvUI_LocPlus\libs\LibTouristClassic-1.0\CallbackHandler-1.0-7\CallbackHandler-1.0.xml:1 (null)

1x Interface_Wrath\FrameXML\Bindings.xml:1 ElvUI_LocPlus\libs\load_libs_wrath.xml:1 ElvUI_LocPlus\libs\LibTouristClassic-1.0\lib.xml:1 ElvUI_LocPlus\libs\LibTouristClassic-1.0\CallbackHandler-1.0\CallbackHandler-1.0.xml:1 (null)

1x Interface_Wrath\FrameXML\Bindings.xml:1 Interface_Wrath\FrameXML\Bindings.xml:1 ElvUI_LocPlus\libs\load_libs_wrath.xml:1 ElvUI_LocPlus\libs\LibTouristClassic-1.0\lib.xml:1 ElvUI_LocPlus\libs\LibTouristClassic-1.0\CallbackHandler-1.0\CallbackHandler-1.0.xml:1 (null)

Benik commented 1 year ago

Which language you are on? The error has to do with localized names in LibTourist

Iowerth commented 1 year ago

Which language you are on? The error has to do with localized names in LibTourist

Russian

Benik commented 1 year ago

My guess is that you probably have to create a ticket in LibTourist Classic (WotLK). https://www.curseforge.com/wow/addons/libtourist-classic/issues

I will leave this ticket open for follow up. Cheers :)

Iowerth commented 1 year ago

I'll close this issue because a new version of LibTouristClassic-1.0 released and now all is fine ;) Thanks!