BenioffOceanInitiative / bbnj

R package for assessing marine biodiversity beyond national jurisdiction (BBNJ)
https://BenioffOceanInitiative.github.io/bbnj
4 stars 0 forks source link

fix taxonomic groupings #3

Closed bbest closed 5 years ago

bbest commented 5 years ago

Per meeting 2019-07-03 BB, MG w/ @mvisalli in notes | bbnj - Google Docs:

Currently of 24,904 species (before masking out high seas), group is NA for 1,176.

to consider

From Morgan's notes:

species data and groupings

References: basis of taxonomic groupings

bbest commented 5 years ago

made taxa changes above in marinebon/gmbi:vignettes/calc.Rmd, but need to still run script and update gmbi + bbnj repos

bbest commented 5 years ago

For others, see https://github.com/marinebon/gmbi/issues/1

mvisalli commented 5 years ago

I believe that the taxonomic breakdown I used for the treemap reflects the changes suggested by Doug and referenced in marinebon/gmbi#1 (i.e. group all cephalopods instead of breaking out squid, changing coastal fishes to bony fishes, and removing forams group)

https://github.com/ecoquants/bbnj/blob/6ce535a3c3e558e59c2557a2cbb17f8503fe3d95/inst/scripts/spp_treemap.Rmd#L36-L56

mvisalli commented 5 years ago

@bbest Doug and I spoke last night and came up w proposed taxonomic clumping for 9 groups:

Invert Bony fishes Marine Mammals Corals Cephalopods Seagrasses Sharks & rays Tunas & billfishes Other

How does that look to you? If ok, I can copy the code from gmbi where you define taxonomic groups and modify to reflect this breakdown & send you updated code to plug in -- is that helpful?

mvisalli commented 5 years ago

Code for updating taxonomic clumping here: https://github.com/ecoquants/bbnj/blob/3765f44f41d503ea9c5ceb15b9406b128f624199/inst/scripts/spp_treemap_DJM.Rmd#L36-L43

bbest commented 5 years ago

TODO: get map app to show all taxonomic groups##

mvisalli commented 5 years ago

Low priority items (especially since @bbest just re-ran this -- sorry!):

bbest commented 5 years ago

Hi @mvisalli,

Just to confirm this edit:

Do you mean, make sure that Teuthida is actively excluded (!Order %in%) from Cephalopods and included (Order %in%) in Squids per Squid | Wikipedia?

This was in the code but not the markdown documentation. I'm applying the rest of the fixes to groups01 (+ groups02 & groups03).

mvisalli commented 5 years ago

Hi @bbest,

It was my understanding that we wanted to include Squid in the group Cephalopods rather than breaking out into "Squids" and "Non-Squid Cephalopods." Does that sounds ok to you?