Closed bbest closed 5 years ago
made taxa changes above in marinebon/gmbi:vignettes/calc.Rmd, but need to still run script and update gmbi + bbnj repos
For others, see https://github.com/marinebon/gmbi/issues/1
I believe that the taxonomic breakdown I used for the treemap reflects the changes suggested by Doug and referenced in marinebon/gmbi#1 (i.e. group all cephalopods instead of breaking out squid, changing coastal fishes to bony fishes, and removing forams group)
@bbest Doug and I spoke last night and came up w proposed taxonomic clumping for 9 groups:
Invert Bony fishes Marine Mammals Corals Cephalopods Seagrasses Sharks & rays Tunas & billfishes Other
How does that look to you? If ok, I can copy the code from gmbi where you define taxonomic groups and modify to reflect this breakdown & send you updated code to plug in -- is that helpful?
Code for updating taxonomic clumping here: https://github.com/ecoquants/bbnj/blob/3765f44f41d503ea9c5ceb15b9406b128f624199/inst/scripts/spp_treemap_DJM.Rmd#L36-L43
TODO: get map app to show all taxonomic groups##
Low priority items (especially since @bbest just re-ran this -- sorry!):
Class == "Cephalopoda" ~ "Cephalopods"
)Hi @mvisalli,
Just to confirm this edit:
Class == "Cephalopoda" ~ "Cephalopods"
)Do you mean, make sure that Teuthida is actively excluded (!Order %in%
) from Cephalopods and included (Order %in%
) in Squids per Squid | Wikipedia?
Class == "Cephalopoda" & !Order %in% c("Myopsida","Oegopsida","Teuthida")
Order %in% c("Myopsida","Oegopsida","Teuthida")
This was in the code but not the markdown documentation. I'm applying the rest of the fixes to groups01
(+ groups02
& groups03
).
Hi @bbest,
It was my understanding that we wanted to include Squid in the group Cephalopods rather than breaking out into "Squids" and "Non-Squid Cephalopods." Does that sounds ok to you?
Per meeting 2019-07-03 BB, MG w/ @mvisalli in notes | bbnj - Google Docs:
Currently of 24,904 species (before masking out high seas), group is NA for 1,176.
to consider
From Morgan's notes:
species data and groupings
Assign Taxonomic Groups in Calculate Indicators • gmbi: assignment performed here
spp.csv
References: basis of taxonomic groupings