search

BenjV / autosub

35 stars 8 forks source link

Setting "Allow Hearing Impaired subs" #21

Closed gillesoorts closed 6 years ago

gillesoorts commented 6 years ago

Would it be possible to check when the setting "Allow Hearing Impaired subs" is working?

I've unchecked the option, but I keep on getting HI subs. I know the option isn't working on opensubtitles and subscene, I'll check other sources as soon I get a sub downloaded from them.

Thanks, Gilles

BenjV commented 6 years ago

It is working on both Addic7ed and Opensubtitles. On subscene and podnapisi not. The problem is that a lot of sub uploaders don't mark the sub as Hearing Impaired.

Also all the web-dl always have English subtitles with Hearing Impaired subs embedded in the .mkv container.

gillesoorts commented 6 years ago

Thanks for the info!

I created the Issue because I recently occurred problems with a specific subtitle. AutoSub downloaded a HI version of the subtitle for Ray Donovan S05E09 from Subscene.

I checked the website manually, and there are both HI and non-HI versions of the subtitles (check this screenshot). But maybe this isn't available in their API?

BenjV commented 6 years ago

Subscene and Podnapisi don't have an API. Those sites are searched via http://www.subtitleseeker.com/ and they don't have the possibility to select on Hearing Impaired. Besides that, most of the subs on those sites are also found on Opensubtitles and/or Addic7ed, so I would suggest (as I myself do) to skip searching on subscene and podnapisi.

gillesoorts commented 6 years ago

Thanks for the info, I disabled Subscene and Podnapisi.

It might be helpful to mention that these two sources don't support the HI option in an additional information popup for the "Allow Hearing Impaired subs" option?